Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the 'chromatic.config.json' configuration file and update GitHub Action docs #330

Merged
merged 5 commits into from
Dec 2, 2023

Conversation

ghengeveld
Copy link
Member

@ghengeveld ghengeveld commented Dec 1, 2023

Explains the use of chromatic.config.json, updates the config options table, removes the config table from the GitHub Action docs (referring to the generic table instead) and adds a chapter about versioning the GitHub Action.

Copy link

netlify bot commented Dec 1, 2023

‼️ Deploy request for chromatic-docs rejected.

Learn more in the Netlify docs

Name Link
🔨 Latest commit 814efca

Copy link

github-actions bot commented Dec 1, 2023

@github-actions github-actions bot temporarily deployed to pull request December 1, 2023 21:19 Inactive
@domyen
Copy link
Member

domyen commented Dec 1, 2023

Thanks! This looks good to me. I committed some typo fixes.

@ghengeveld When does the config file officially roll out and which version of Chromatic CLI supports it?

@github-actions github-actions bot temporarily deployed to pull request December 1, 2023 22:30 Inactive
@ghengeveld ghengeveld changed the title Document the 'chromatic.json' configuration file and update GitHub Action docs Document the 'chromatic.config.json' configuration file and update GitHub Action docs Dec 2, 2023
@ghengeveld
Copy link
Member Author

ghengeveld commented Dec 2, 2023

@domyen Support for chromatic.config.json was added in 7.2.0. We haven't set an "official" rollout date but I think that's where we're at.

Note I was mistakenly referring to chromatic.json but that should be chromatic.config.json. I fixed that now.

@github-actions github-actions bot temporarily deployed to pull request December 2, 2023 14:25 Inactive
@github-actions github-actions bot temporarily deployed to pull request December 2, 2023 14:30 Inactive
@ghengeveld ghengeveld merged commit dc71110 into main Dec 2, 2023
2 checks passed
@ghengeveld ghengeveld deleted the configuration-file-and-action-docs branch December 2, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants