Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust path in Docs for E2E monorepo support #307

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Adjust path in Docs for E2E monorepo support #307

merged 1 commit into from
Nov 13, 2023

Conversation

thafryer
Copy link
Member

@thafryer thafryer commented Nov 4, 2023

No description provided.

@netlify Netlify
Copy link

netlify bot commented Nov 4, 2023 •
edited
Loading

‼️ Deploy request for chromatic-docs rejected.

Learn more in the Netlify docs →

Name Link
🔨 Latest commit 3a5c244

@thafryer thafryer changed the title Adjust path in Docs Adjust path in Docs for E2E monorepo support Nov 4, 2023
@thafryer thafryer requested a review from skitterm November 4, 2023 00:13
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 4, 2023 •
edited
Loading

🚀 Deployed on https://deploy-preview-monorepo-e2e-correction-3a5c244--chromatic-docs.netlify.app

@github-actions github-actions bot temporarily deployed to pull request November 4, 2023 00:15 Inactive
@github-actions github-actions bot temporarily deployed to pull request November 4, 2023 00:16 Inactive
skitterm
skitterm approved these changes Nov 4, 2023
View reviewed changes
Copy link
Member

@skitterm skitterm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thafryer the path change looks good!

For the customer I only got this working when running this from the chromatic command, so I'm not sure it'll work for archive-storybook and build-archive-storybook (I can check Monday), but this is an improvement over what we currently have.

@elseloop elseloop merged commit 10c0d02 into main Nov 13, 2023
2 checks passed
@elseloop elseloop deleted the monorepo-e2e-correction branch November 13, 2023 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skitterm skitterm skitterm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thafryer @skitterm @elseloop