-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update E2E tests Docs to accomodate for running in Monorepos #306
Conversation
AP-3614 Supporting Yarn workspaces
What? With a Yarn workspace, we could automatically identify where the Storybook config and archive locations are in ancestor directories of the file system, without the user having to specify.. Background A customer that is using e2e had this issue (Their playwright tests were in a subproject, but everything was installed at the root level since they use hoisting). They were able to get things working by specifying where the Storybook config is (using the Details This user is using yarn v3, not sure how common that is. They were able to get around specifying the
|
👷 Deploy request for chromatic-docs pending review.A Netlify team Owner will need to approve the deploy before you can run your build. Are you a team Owner? Visit the deploys page to approve it → Need more help? Learn more in the Netlify docs →
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thafryer Thanks for putting this together. Some syntax will need to change (/latest
should now be chromatic-archives
), but even with changes I was unable to get things working correctly as I had with the user I helped.
If you have time to pair on this today, I think we could figure it out quickly and know what to document.
5993a37
to
9434774
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thafryer I added some small changes for clarity, but this looks great—thank you!
We had a customer try setting up E2E Visual tests in a monorepo (Yarn workspaces) and run into issues. This updates the docs to leverage their workaround until we improve the onboarding workflow.