Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add E2E test configuration options #304

Merged
merged 6 commits into from
Nov 3, 2023
Merged

Conversation

tevanoff
Copy link
Contributor

@tevanoff tevanoff commented Nov 1, 2023

This adds all of the new E2E configuration options and examples for how use in Playwright.

Copy link

netlify bot commented Nov 1, 2023

👷 Deploy request for chromatic-docs accepted.

Name Link
🔨 Latest commit 6da4678
🔍 Latest deploy log https://app.netlify.com/sites/chromatic-docs/deploys/65429ad96efdcf0008d9ed8c

@tevanoff tevanoff requested a review from elseloop November 1, 2023 18:37
Copy link

github-actions bot commented Nov 1, 2023

@github-actions github-actions bot temporarily deployed to pull request November 1, 2023 18:39 Inactive
@github-actions github-actions bot temporarily deployed to pull request November 1, 2023 22:19 Inactive
@elseloop
Copy link
Contributor

elseloop commented Nov 3, 2023

@tevanoff I just pushed a couple small content updates to this branch. Can you please review them to make sure I haven't changed meaning at all?

Copy link
Contributor

@elseloop elseloop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you! I added a couple small changes for clarity and to align with larger patterns. Once you confirm that those changes don't change your meaning, this is good to go.

@@ -338,14 +341,14 @@ These options control how the Chromatic archive fixture behaves.

These options control how Chromatic behaves concerning the stories of your archives.

| Option | Type | Description |
| Option | Type | Chromatic Docs |
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is much better!

@tevanoff tevanoff force-pushed the todd/update-e2e-configuration branch from 0c4a0e8 to aba0239 Compare November 3, 2023 20:19
@github-actions github-actions bot temporarily deployed to pull request November 3, 2023 20:21 Inactive
@elseloop elseloop merged commit 52c389a into main Nov 3, 2023
4 checks passed
@elseloop elseloop deleted the todd/update-e2e-configuration branch November 3, 2023 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants