Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs - VT addon Tweaks to the FAQ page #274

Merged
merged 3 commits into from
Oct 17, 2023
Merged

Conversation

jonniebigodes
Copy link
Contributor

With this pull request the FAQ was updated to contain some items related to the visual testing addon. Some considerations, similar to other pull requests, this one will also be targeting the next branch per what's been discussed, and I'm aware that some of the items already exist in the vt addon page, to unblock customers, however, asides from the yarn issue the other ones should live here and we keep that page more streamlined.

@jonniebigodes jonniebigodes added the Visual test addon Documentation changes related to the addon label Sep 23, 2023
@jonniebigodes jonniebigodes self-assigned this Sep 23, 2023
Copy link
Contributor

@elseloop elseloop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one small change called out in a comment and pushed a couple even smaller ones. Nothing blocking here. Looks great!

faq.md Outdated
<details>
<summary>Can I enable TurboSnap with the addon?</summary>

TurboSnap is available for the addon at an experimental stage. If you already enabled it in your configuration file (i.e., `chromatic.config.json`), running a build with the addon will automatically detect and run tests based on the configuration provided.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you already enabled it in your configuration file

It's unclear what the it in enabled it refers to here? I'd suggest using the noun in place of the pronoun instead.

@jonniebigodes jonniebigodes merged commit 3818062 into next Oct 17, 2023
@jonniebigodes jonniebigodes deleted the docs_vt_faq_updates branch October 17, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Visual test addon Documentation changes related to the addon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants