Fixed some url encoding issues.

chroma-x · Feb 1, 2017 · a7f0fb9 · a7f0fb9
1 parent ffac304
commit a7f0fb9
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/src/SecretSharing/SharedSecretUrlEncoder/HotpSharedSecretUrlEncoder.php b/src/SecretSharing/SharedSecretUrlEncoder/HotpSharedSecretUrlEncoder.php
@@ -21,7 +21,7 @@ public function encode($keyName, $sharedSecret, $issuer = null)
 		$sharedSecret = bin2hex($sharedSecret);
 		$encoded = 'otpauth://hotp/' . rawurlencode($keyName) . '?secret=' . $sharedSecret;
 		if (!is_null($issuer)) {
-			$encoded .= '&issuer=' . $issuer;
+			$encoded .= '&issuer=' . rawurlencode($issuer);
 		}
 		return $encoded;
 	}

diff --git a/src/SecretSharing/SharedSecretUrlEncoder/TotpBase32SharedSecretUrlEncoder.php b/src/SecretSharing/SharedSecretUrlEncoder/TotpBase32SharedSecretUrlEncoder.php
@@ -24,7 +24,7 @@ public function encode($keyName, $sharedSecret, $issuer = null)
 		$sharedSecret = Base32::encodeByteStr($sharedSecret, true);
 		$encoded = 'otpauth://totp/' . rawurlencode($keyName) . '?secret=' . $sharedSecret;
 		if (!is_null($issuer)) {
-			$encoded .= '&issuer=' . $issuer;
+			$encoded .= '&issuer=' . rawurlencode($issuer);
 		}
 		return $encoded;
 	}

diff --git a/src/SecretSharing/SharedSecretUrlEncoder/TotpSharedSecretUrlEncoder.php b/src/SecretSharing/SharedSecretUrlEncoder/TotpSharedSecretUrlEncoder.php
@@ -21,7 +21,7 @@ public function encode($keyName, $sharedSecret, $issuer = null)
 		$sharedSecret = bin2hex($sharedSecret);
 		$encoded = 'otpauth://totp/' . rawurlencode($keyName) . '?secret=' . $sharedSecret;
 		if (!is_null($issuer)) {
-			$encoded .= '&issuer=' . $issuer;
+			$encoded .= '&issuer=' . rawurlencode($issuer);
 		}
 		return $encoded;
 	}