Increased coverage.

chroma-x · Apr 15, 2016 · 548c3e0 · 548c3e0
1 parent 84fd975
commit 548c3e0
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 4 deletions.
diff --git a/test/Validation/YubicoOtp/ParserTest.php b/test/Validation/YubicoOtp/ParserTest.php
@@ -12,15 +12,29 @@
 class ParserTest extends \PHPUnit_Framework_TestCase
 {
 
+	const OTP = 'ccccccfcttfikkgitudletutjneikkrfcugnuhikdbhj';
+
 	/**
 	 * @throws ParserException
 	 */
-	public function testParse()
+	public function testParseInvalid()
 	{
 		$this->setExpectedException(get_class(new ParserException()));
 		$parser = new Parser();
 		$parser->parse('');
 		$parser->parse('123456789');
 	}
 
+	/**
+	 * @throws ParserException
+	 */
+	public function testParseValid()
+	{
+		$parser = new Parser();
+		$parser->parse(self::OTP);
+		$this->assertEquals(self::OTP, $parser->getOtpEffective());
+		$this->assertEmpty($parser->getPassword());
+		$this->assertEquals('kkgitudletutjneikkrfcugnuhikdbhj', $parser->getCiphertext());
+	}
+
 }
diff --git a/test/Validation/YubicoOtp/ValidatorTest.php b/test/Validation/YubicoOtp/ValidatorTest.php
@@ -10,7 +10,7 @@
 class ValidatorTest extends \PHPUnit_Framework_TestCase
 {
 
-	const PUBLIC_ID = 'ccccccfcttfik';
+	const PUBLIC_ID = 'ccccccfcttfi';
 
 	public function testValidateMalformed()
 	{
@@ -21,8 +21,11 @@ public function testValidateMalformed()
 		$isValid = $validator->validate('12345678', self::PUBLIC_ID);
 		$this->assertEquals(false, $isValid);
 		// Wellformed
-		$isValid = $validator->validate('ccccccfcttfikkgitudletutjneikkrfcugnuhikdbhj', self::PUBLIC_ID);
-		$this->assertEquals(false, $isValid);
+		$validator->validate('ccccccfcttfikkgitudletutjneikkrfcugnuhikdbhj', self::PUBLIC_ID);
+		$this->assertEquals(false, $validator->isValid());
+		// Parser
+		$parser = $validator->getOtpParser();
+		$this->assertInstanceOf('\OathServerSuite\Validation\YubicoOtp\Parser', $parser);
 	}
 
 }