Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(response): set content-length header for empty response #58

Merged
merged 3 commits into from
Jun 23, 2024

Conversation

christoph-fricke
Copy link
Owner

@christoph-fricke christoph-fricke commented Jun 23, 2024

This PR updates response(...).empty() to set the content-length header to 0 by default if the header is not provided explicitly. Other response factories already set the header as they delegate to MSW, which sets the header already.

closes #56

Copy link

changeset-bot bot commented Jun 23, 2024

⚠️ No Changeset found

Latest commit: b8be20a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@christoph-fricke christoph-fricke merged commit f08acf1 into main Jun 23, 2024
1 check passed
@christoph-fricke christoph-fricke deleted the feat/#56-empty-content-length branch June 23, 2024 16:30
@github-actions github-actions bot mentioned this pull request Jun 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set "Content-Length" header for response(...).emtpy()
1 participant