Skip to content
This repository has been archived by the owner on Mar 20, 2021. It is now read-only.

Add linux support #5

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

aeruder
Copy link

@aeruder aeruder commented Jun 27, 2015

A couple cleanup commits followed by moving acpi functions into a module and then the small addition needed to add Linux support. Exe compiled on Windows 7 32-bit -- tested on Windows 8 64-bit and Arch Linux 64-bit.

aeruder added 4 commits June 27, 2015 02:05
This gets rid of the number being hard-coded since it apparently the
table name is just the little-endian translation of the name to ascii.
Will be splitting this out into linux acpi functions
and windows acpi functions and just getting the clutter
out of the main file.
Adds support to retrieve and return the MSDM table from Linux
@aeruder
Copy link
Author

aeruder commented Jun 29, 2015

I had contemplated if it still made sense to include the compiled executable for Windows in the git repository as opposed to doing a separate build/release (I believe github has some mechanism for storing release files separate from the git repo). Mostly because it already takes a few minutes to clone the repository on my slow work connection.

@christian-korneck
Copy link
Owner

I had contemplated if it still made sense to include the compiled executable for Windows in the git repository

I agree, this was bad practice in the first place. But when I look at the repo's traffic stats, I can see many URLs with "download" links pointing to the raw get_win8key.exe in the trunk. The only reason why the compiled .exe is still in the trunk is to not break these links.

@aeruder
Copy link
Author

aeruder commented Jun 29, 2015

That makes sense. Well, if the rest of this looks good, I'll just update the pull request to not update the .exe (especially not on every commit) as windows functionality is unchanged. Let me know, didn't know if Linux support really fit into your master plan so I will wait to hear from you before I update the pull request.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants