Prefix input to make hash lookup harder #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now, `sha1(input)` is exposed in the URL. For short and well-known passwords, hashes can be looked up easily. E.g. https://www.google.com/search?q=5baa61e4c9b93f3f0682250b6cf8331b7ee68fd8 This URL exposes the password, and it's saved in browsing history. By prefixing the password with a string, such lookups are harder.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now,
sha1(input)is exposed in the URL.For short and well-known passwords, hashes can be looked up easily.
E.g. https://www.google.com/search?q=5baa61e4c9b93f3f0682250b6cf8331b7ee68fd8
This URL exposes the password, and it's saved in browsing history.
By prefixing the password with a string, such lookups are harder.
This breaks existing passwords.
Far better would be a real salt, but that would require the salt state to be embedded in the page (https://en.wikipedia.org/wiki/Salt_(cryptography)).