-
-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v6.0.0 [OLD] #82
Closed
Closed
v6.0.0 [OLD] #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrissimpkins
force-pushed
the
v5
branch
2 times, most recently
from
October 29, 2020 17:08
c8fdcb2
to
4100c8c
Compare
Thank you for the project and you contribution. 💌 |
includes patches to v1.0.3+, the last sequential patch applied is google/zopfli@7113f4e
confirms that Pool is terminated at the end of execution
This is not available in Py2.7. Though Py2.7 is legacy code, we are going to continue to support here for now.
also adds better data descriptions
Closing in favor of a new PR with additional updates. Will cherry pick relevant commits here into the new branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes (so far... This is currently WIP)
black -l 90
source code style in Python sourceTentative
--force
option to overwrite optimized files in place (Add option to replace the original file with -f flag #76), dev branch implementation needs to be refactored withfunctools.partial
approach. This will eliminate the need for a global variable.Notes
Py3.8 on Travis Ubuntu Linux env is broken for some reason. Currently troubleshootingMoved to GH Actions and am now testing across cPy2.7, 3.6 - 3.9, pypy3 on macOS and Linux platforms. All unit tests are passing.TODO