fix: queue job execution timeout #620
Open
+38
−55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @uhliksk Thank you for trying to fix it up. However, I was not able to test it out since there is no test. |
|
Hi @chrisleekr Thank you for a ping. I'll try to reserve some spare time to test and tune a solution this week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moved the timeout processing into a queue to end the job correctly if it's duration is over the timeout.
Related Issue
#594
Motivation and Context
Will prevent non-deterministic behavior of the job queue.
How Has This Been Tested?
This PR is just a proposal for the solution. I'm sorry, I haven't had time to test it.
Screenshots (if appropriate):