Fix call to logging._level #12
Open
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
An additional fix, to get the logging levels to work (I wanted to disable logging by setting logLevel to WARNING) I had to as make the change in the second commit |
chrisb2
reviewed
Apr 11, 2023
| @@ -124,8 +124,8 @@ def __init__(self, shunt_ohms, i2c, max_expected_amps=None, | |||
| log_level -- set to logging.DEBUG to see detailed calibration | |||
| calculations (optional). | |||
| """ | |||
| logging.basicConfig(level=log_level) | |||
There was a problem hiding this comment.
I think we should follow the pattern in the RPi version of this library and check if the logger is already setup, see RPi ina219.py, which was made in this PR?
Open
|
Any updates on this? I'm pretty sure it works and you could just merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just installed your excellent library on an ESP32, and got it working by making this change. I can't say I've read every line of your library and logging.py but it looks like maybe logging._level was removed at some point after you wrote the library?
Anyway I think using self._log.level seems to be the right fix.