Remove custom yaml

src/GitlabCli/GitlabCli.psd1

@@ -1,5 +1,9 @@
 @{
-    ModuleVersion = '1.113.1'
+    ModuleVersion = '1.114.0'
+
+    RequiredModules = @(
+        'powershell-yaml'
+    )
 
     PrivateData = @{
         PSData = @{

src/GitlabCli/Jobs.psm1

@@ -260,25 +260,22 @@ function Test-GitlabPipelineDefinition {
 function Get-GitlabPipelineDefinition {
     [CmdletBinding()]
     param (
-        [Parameter(Mandatory=$false)]
+        [Parameter()]
         [string]
         $ProjectId = '.',
 
-        [Parameter(Mandatory=$false)]
+        [Parameter()]
         [Alias("Branch")]
         [string]
         $Ref,
 
-        [Parameter(Mandatory=$false)]
+        [Parameter()]
         [string]
-        $SiteUrl,
-
-        [switch]
-        [Parameter(Mandatory=$false)]
-        $WhatIf
+        $SiteUrl
     )
 
-    Get-GitlabRepositoryYmlFileContent -ProjectId $ProjectId -FilePath '.gitlab-ci.yml' -Ref $Ref -SiteUrl $SiteUrl
+    Get-GitlabRepositoryFileContent -ProjectId $ProjectId -Ref $Ref -FilePath '.gitlab-ci.yml' -SiteUrl $SiteUrl |
+        ConvertFrom-Yaml
 }
 
 <#

src/GitlabCli/RepositoryFiles.psm1

@@ -223,32 +223,27 @@ function Get-GitlabRepositoryTree {
 }
 
 function Get-GitlabRepositoryYmlFileContent {
+    [Obsolete("Use Get-GitlabRepositoryFileContent instead")]
     [CmdletBinding()]
     param (
-        [Parameter(Mandatory=$false)]
+        [Parameter()]
         [string]
         $ProjectId = '.',
 
-        [Parameter(Position=0, Mandatory=$true)]
+        [Parameter(Position=0, Mandatory)]
         [string]
         $FilePath,
 
-        [Parameter(Mandatory=$false)]
+        [Parameter()]
         [Alias("Branch")]
         [string]
         $Ref,
 
-        [Parameter(Mandatory=$false)]
+        [Parameter()]
         [string]
         $SiteUrl
     )
-
-    $Yml = $(Get-GitlabRepositoryFileContent -ProjectId $ProjectId -Ref $Ref -FilePath $FilePath -SiteUrl $SiteUrl)
-    $Hash = $([YamlDotNet.Serialization.Deserializer].GetMethods() |
-        Where-Object { $_.Name -eq 'Deserialize' -and $_.ReturnType.Name -eq 'T' -and $_.GetParameters().ParameterType.Name -eq 'String' }). `
-        MakeGenericMethod(
-            [object]). `
-        Invoke($(New-Object 'YamlDotNet.Serialization.Deserializer'), $Yml)
-
-    return $Hash | ConvertTo-Json -Depth 100 | ConvertFrom-Json # the JSON "double-tap" coerces HashTables into PSCustomObject (including nested children)
+
+    Get-GitlabRepositoryFileContent -ProjectId $ProjectId -Ref $Ref -FilePath $FilePath -SiteUrl $SiteUrl |
+        ConvertFrom-Yaml
 }

src/GitlabCli/_Init.ps1

@@ -59,38 +59,3 @@ $global:GitlabIdentityPropertyNameExemptions=@{
     'Gitlab.Variable'                  = ''
 }
 $global:GitlabJobLogSections            = New-Object 'Collections.Generic.Stack[string]'
-
-# Remove the following as part of https://github.com/chris-peterson/pwsh-gitlab/issues/77
-# Adapted from
-# https://github.com/cloudbase/powershell-yaml/blob/master/Load-Assemblies.ps1
-
-$Here = Split-Path -Parent $MyInvocation.MyCommand.Path
-
-function Initialize-Assembly {
-    $LibDir = Join-Path $Here "lib"
-
-    return [Reflection.Assembly]::LoadFrom($(Join-Path $libDir "YamlDotNet.dll"))
-}
-
-function Initialize-Assemblies {
-    $RequiredTypes = @(
-        "Parser", "MergingParser", "YamlStream",
-        "YamlMappingNode", "YamlSequenceNode",
-        "YamlScalarNode", "ChainedEventEmitter",
-        "Serializer", "Deserializer", "SerializerBuilder",
-        "StaticTypeResolver"
-    )
-
-    $YamlDotNet = [System.AppDomain]::CurrentDomain.GetAssemblies() | Where-Object Location -Match "YamlDotNet.dll"
-    if (!$YamlDotNet) {
-        return Initialize-Assembly
-    }
-
-    foreach ($i in $RequiredTypes){
-        if ($i -notin $YamlDotNet.DefinedTypes.Name) {
-            throw "YamlDotNet is loaded but missing required types ($i). Older version installed on system?"
-        }
-    }
-}
-
-Initialize-Assemblies | Out-Null