Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding optional interfaceAssociatedAddress to to UDPReceiver/UDPSender/OD4Session c'tor #13

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

freol35241
Copy link

Adding optional constructor argument for allowing explicit interface address to be used when joining a multicast group. This makes it possible to explicitly set which interface that should be used when joining a multicast group on a computer with multiple NICs.

…address to be used when joining a multicast group.
@freol35241 freol35241 changed the title Adding optional interfaceAssociatedAddress to UDPReceiver c'tor Adding optional interfaceAssociatedAddress to to UDPReceiver/UDPSender/OD4Session c'tor Jul 9, 2021
@freol35241 freol35241 force-pushed the interface_associated_address_udp_receiver branch from 9360598 to eed9266 Compare July 9, 2021 14:11
@freol35241
Copy link
Author

@chrberger
Updated this PR with similar corresponding changes in UDPSender and OD4Session.

I am a bit unsure whether I managed to put all the ifdef blocks for the different OS:s correctly. There are some parts of the existing ones I cant wrap my head around...

Also, if you have an idea about how to include this in the automatic test suite, I am all ears.

Now, some holidays, so no need to stress the review ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant