Fix resource pool regression in persistent-mysql-haskell, persistent. - #5
Open
swamp-agr wants to merge 2 commits into
Open
Fix resource pool regression in persistent-mysql-haskell, persistent.#5swamp-agr wants to merge 2 commits into
persistent-mysql-haskell, persistent.#5swamp-agr wants to merge 2 commits into
Conversation
swamp-agr
force-pushed
the
fix-resource-pool-regression
branch
from
August 26, 2026 10:44
e9825fc to
7d75de5
Compare
Author
|
Note: this is a PR into "persistent-mysql-haskell-9.2" branch of the current fork. |
|
Will try to have a look at the code tomorrow, but since this resource-pool update also caused issues in hedis and I would expect a library like resource-pool to not make it so easy to leak things, I'm wondering why the behaviour was changed this way and why we aren't fixing it more "centrally". Do you know? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes regression introduced in
resource-pool-0.5.0.0. It sets bracket on connection errors and makes closing connection uninterruptible. Second commit fixesloggedClosefrompersistentby making it uninterruptible since it could be interrupted, resource-pool is no longer guaranteeing that.