Refactor Output_float32#469
Merged
evaneschneider merged 26 commits intocholla-hydro:devfrom Mar 18, 2026
Merged
Conversation
Merged
Merged
evaneschneider
approved these changes
Mar 18, 2026
Collaborator
evaneschneider
left a comment
evaneschneider
left a comment
There was a problem hiding this comment.
Only one minor comment, otherwise I think this looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To be reviewed after #477 is merged
In short this aims to make use of the new
FieldInfotype and refactor parsing of Float32 parameters. TheOutput_float32logic is now implemented by theF32FieldWriterclass.I have factored out a bunch of common functionality between
F32FieldWriterandFieldWriter. I have gone to great lengths to retain historical behavior. Once we reconcile all of the inconsistencies, a bunch of duplicated code can be removed