Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run nightly nightly #765

Closed
wants to merge 27 commits into from
Closed

run nightly nightly #765

wants to merge 27 commits into from

Conversation

mikemhenry
Copy link
Contributor

@mikemhenry mikemhenry commented Feb 12, 2021

Instead of including checks against nightly openmm builds on ever PR, we will run checks every night and if they fail make an issue on github

This PR will be smaller when PR #760 and PR #763 get merged in.

@codecov
Copy link

codecov bot commented Feb 12, 2021

Codecov Report

Merging #765 (5537690) into master (8ea1b30) will not change coverage.
The diff coverage is n/a.

@mikemhenry
Copy link
Contributor Author

@jaimergp Not exactly what is wrong with the syntax in the new Nightly.yml file, but my idea was to move the nightly testing as part of a cron job and not test PRs against nightly. This should make a github issue when nightly fails, which should help keep those issues visible.

@jaimergp
Copy link
Member

What if instead of having different workflows we use conditionals based on github.event_name?

Co-authored-by: Jaime Rodríguez-Guerra <[email protected]>
@mikemhenry
Copy link
Contributor Author

That could work and cuts down on the duplication. At one point I split the checks into a new workflow so they wouldn't block auto merging or make it look like our build was failing when it wasn't, but I think marking the checks as not required should fix that, I'll give it a try.

Co-authored-by: Jaime Rodríguez-Guerra <[email protected]>
@mikemhenry
Copy link
Contributor Author

Part of what I'm trying to do is not have our build badge be red, but I think I've fixed that by chancing which checks are required

@mikemhenry
Copy link
Contributor Author

Going to work on making nightly work

@mikemhenry mikemhenry closed this Apr 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants