Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add training parameter "profiler" #322

Merged
merged 2 commits into from
Nov 21, 2024
Merged

Add training parameter "profiler" #322

merged 2 commits into from
Nov 21, 2024

Conversation

MarshallYan
Copy link
Collaborator

Pull Request Summary

Provide a brief description of the PR's purpose here.

Key changes

Notable points that this PR has either accomplished or will accomplish.

  • Change 1

Questions

  • Question 1

Associated Issue(s)

  • Issue 1

Pull Request Checklist

  • Issue(s) raised/addressed and linked
  • Includes appropriate unit test(s)
  • Appropriate docstring(s) added/updated
  • Appropriate .rst doc file(s) added/updated
  • PR is ready for review

@codecov-commenter
Copy link

codecov-commenter commented Nov 20, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 78.69%. Comparing base (3e57f87) to head (16bbae2).

Additional details and impacted files
---- 🚨 Try these New Features:

@chrisiacovella
Added enum for profiler, debug statement if profiler is being used, a…
16bbae2 
…nd added dipole moment values to phalkethoh default properties.
chrisiacovella
chrisiacovella approved these changes Nov 21, 2024
View reviewed changes
Copy link
Member

@chrisiacovella chrisiacovella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a very good addition.

@chrisiacovella chrisiacovella merged commit 024e297 into main Nov 21, 2024
10 checks passed
@chrisiacovella chrisiacovella deleted the dev-profiler-from-training-config branch November 21, 2024 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisiacovella chrisiacovella chrisiacovella approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MarshallYan @codecov-commenter @chrisiacovella