-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to AIMNet2 architecture for radial and vector embedding #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to AIMNet2 architecture for radial and vector embedding. Updated the wiki entry.
Summary of changes:
This PR introduces significant improvements to the AimNet2 architecture, specifically in handling radial and vector contributions. The original implementation was limited in capturing angular dependencies and omitted clear aggregation and transformations for certain atomic interactions. These changes aim to enhance model expressiveness and bring it closer to the (somewhat vague) description in the original paper.
Key Modifications:
gs
andgv
tensors are introduced to represent radial and vector (angular) symmetry functions, respectively. The radial basis (gs
) captures pairwise distances, whilegv
encodes directional vectors for atom pairs.gv
and anagh
transformation matrix capture the vector (angular) contributions. This setup adds expressiveness by handling directional information, aligning the model closer with angular-dependent symmetry functions. The operation structure:torch.einsum("pa, pdg, agh -> phd", a_j, gv, agh)
ensures the features align over vector components.f
is applied todelta_q
(charge updates), which is introduced to improve control over charge accumulation during message-passing steps. This approach allows initializing and incrementally updating charges in a more controlled manner.Paper Vague on Equations
The original paper is vague regarding details, especially for the equations governing vector contributions and aggregation. This implementation assumes certain interpretations based on the partial information given, and are not easily to decode. This is therefore not a literal implementation of AimNet2, but only a interpretation.