Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix center of mass shifting #304

Merged
merged 2 commits into from
Oct 29, 2024

Conversation

chrisiacovella
Copy link
Member

@chrisiacovella chrisiacovella commented Oct 29, 2024

Center of mass shifting was failing when a dataset had multiple conformers (accidentally was using indices for the atom_numbers, which are not duplicated between multiple conformers, instead of using the indices that referred to series data). As such, this was working fine for qm9, which was used for testing, but failing for all other datasets PhAlkEthOH.

Key changes

Notable points that this PR has either accomplished or will accomplish.

  • Revise indexing in center of mass removal
  • Add tests over PhAlkEthOH that also include ensuring r_ij and d_ij match (i.e., ensure we are invariant under translation)

Associated Issue(s)

  • Issue 1

Pull Request Checklist

  • Issue(s) raised/addressed and linked
  • Includes appropriate unit test(s)
  • Appropriate docstring(s) added/updated
  • Appropriate .rst doc file(s) added/updated
  • PR is ready for review

…ic_numbers array (single_atom) not series_atom properties. This was causing shifting to be imporperly applied for any system with more than one conformer.
@codecov-commenter
Copy link

codecov-commenter commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.33%. Comparing base (710d1e4) to head (9a3236e).
Report is 3 commits behind head on main.

Additional details and impacted files

Copy link
Member

@wiederm wiederm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! That should fix the issue!

@wiederm wiederm enabled auto-merge October 29, 2024 13:29
@wiederm wiederm merged commit f20c713 into choderalab:main Oct 29, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants