Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make dimensions of predicted properties consistent #300

Merged
merged 8 commits into from
Oct 29, 2024
Merged

Conversation

wiederm
Copy link
Member

@wiederm wiederm commented Oct 25, 2024

Pull Request Summary

A few changes that are too small for a separate PR are combined here.

Key changes

Notable points that this PR has either accomplished or will accomplish.

  • add ani tests for radial symmetry functions
  • change shape of the energy output

Questions

  • Question 1

Associated Issue(s)

  • Issue 1

Pull Request Checklist

  • Issue(s) raised/addressed and linked
  • Includes appropriate unit test(s)
  • Appropriate docstring(s) added/updated
  • Appropriate .rst doc file(s) added/updated
  • PR is ready for review

@wiederm wiederm changed the title small refactoring all over the place make dimensions of predicted properties consistent Oct 26, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.16%. Comparing base (046cf24) to head (f40b674).

Additional details and impacted files

@wiederm wiederm self-assigned this Oct 26, 2024
@wiederm wiederm merged commit 45be449 into main Oct 29, 2024
6 checks passed
@wiederm wiederm deleted the dev-new-tests branch October 29, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants