Check if dgl 2.3.0 works #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Presumably this would need to also have a release, too? |
|
If it JustWorks ™️ then I should be able to just bump the pin on the conda-forge repo. The unit tests ran fine on my last check, just python 3.9 failing b/c of amber tools, so it is likely we won't need a new release. |
|
And the other error is just versioneer needing and update which I can do in this PR (and is already fixed on conda-forge with a patch) |
|
I'll leave it all up to you, but if the 1.x pin in the current release was just precautionary (and major changes here aren't needed to work with 2.x) as seems to be the case here, great! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.