-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(#1028) Update icons with font awesome accesibility approach #1076
Open
LeaDevelop
wants to merge
15
commits into
chocolatey:master
Choose a base branch
from
LeaDevelop:(#1028)-docs-update-fix-emojis
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
(#1028) Update icons with font awesome accesibility approach #1076
LeaDevelop
wants to merge
15
commits into
chocolatey:master
from
LeaDevelop:(#1028)-docs-update-fix-emojis
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mind including screen reader consideration - https://docs.fontawesome.com/web/dig-deeper/accessibility
…ility, disabled for screen reader
…some accessibility
…x-emojis' into (chocolatey#1028)-docs-update-fix-emojis
Hey @LeaDevelop thanks for the PR! We may need to make some informed decisions on which of these to keep and which icons to remove completely. I will post a review with suggestions when we start our focus on accessibility in the coming weeks. |
Sounds like a plan 👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
Unicode emoticons (⚙💾🔍➕📅🗑) replaced with font awesome accessibility ones.
Motivation and Context
Motivation was to improve the user experience and ensure consistent visual representation across different platforms and devices. Previously, emoticons were not considering accessibility, which could lead to confusion or misinterpretation of the documentation when using screen reader.
Testing
Pages that were validated:
Change Types Made
Change Checklist