-
Notifications
You must be signed in to change notification settings - Fork 909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite Get-ChocolateyPath cmdlet #3646
base: feature/cmdlets
Are you sure you want to change the base?
Conversation
Rewrite of the Get-ChocolateyPath into C# cmdlet, and associated changes to helper methods.
Test all the things!
557de2c
to
69703d8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few minor things.
@@ -0,0 +1,12 @@ | |||
using System; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
using System; | |
// Copyright © 2017 - 2025 Chocolatey Software, Inc | |
// Copyright © 2011 - 2017 RealDimensions Software, LLC | |
// | |
// Licensed under the Apache License, Version 2.0 (the "License"); | |
// you may not use this file except in compliance with the License. | |
// | |
// You may obtain a copy of the License at | |
// | |
// http://www.apache.org/licenses/LICENSE-2.0 | |
// | |
// Unless required by applicable law or agreed to in writing, software | |
// distributed under the License is distributed on an "AS IS" BASIS, | |
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | |
// See the License for the specific language governing permissions and | |
// limitations under the License. | |
using System; |
public enum ChocolateyPathType | ||
{ | ||
PackagePath, | ||
InstallPath, | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this have the xml help comments?
@@ -0,0 +1,73 @@ | |||
using Chocolatey.PowerShell; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
using Chocolatey.PowerShell; | |
// Copyright © 2017 - 2025 Chocolatey Software, Inc | |
// Copyright © 2011 - 2017 RealDimensions Software, LLC | |
// | |
// Licensed under the Apache License, Version 2.0 (the "License"); | |
// you may not use this file except in compliance with the License. | |
// | |
// You may obtain a copy of the License at | |
// | |
// http://www.apache.org/licenses/LICENSE-2.0 | |
// | |
// Unless required by applicable law or agreed to in writing, software | |
// distributed under the License is distributed on an "AS IS" BASIS, | |
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | |
// See the License for the specific language governing permissions and | |
// limitations under the License. | |
using Chocolatey.PowerShell; |
Description Of Changes
Motivation and Context
See #3477
Testing
Invoke-Tests.ps1 -Tag GetChocolateyPath
Operating Systems Testing
Windows 11
Change Types Made
Change Checklist
Related Issue
Part of #3477
Docs PR: chocolatey/docs#1152