Skip to content

Conversation

Apteryx0
Copy link

@Apteryx0 Apteryx0 commented Jan 11, 2017

Implements a subset of the functionality, support for packages.config
files in the upgrade command. Also extended the tests to test the new
code. I did not see any value in implementing package.config support for
uninstall because the problem I am interested in solving is being able
to upgrade multiple packages each with a specific version in one
command. Since uninstall (generally?) doesn't require specifying a
version this can be done on the uninstall command line, i.e. just give
the package list to uninstall.

Closes #3721

@ferventcoder
Copy link
Member

Nice!

@ferventcoder
Copy link
Member

Your commit summary is missing some words ;)

@ferventcoder ferventcoder self-assigned this Jan 11, 2017
@Apteryx0 Apteryx0 force-pushed the (GH-533)UpgradeViaPackagesConfig branch from 37a13e2 to 3046bc8 Compare January 11, 2017 04:29
@Apteryx0
Copy link
Author

Oops - is that better?

@Apteryx0 Apteryx0 changed the title (GH-533) (GH-533) Support packages.config file in upgrade Jan 11, 2017
@ferventcoder
Copy link
Member

Much better. 👍

@ferventcoder
Copy link
Member

Please don't merge master - Merges are very bad in feature branches.

I thought we had that outlined in our CONTRIBUTING document, but it's more implied than called out directly - https://github.com/chocolatey/choco/blob/master/CONTRIBUTING.md#submit-pull-request-pr and https://github.com/chocolatey/choco/blob/master/CONTRIBUTING.md#respond-to-feedback-on-pull-request

@Apteryx0
Copy link
Author

Apteryx0 commented May 1, 2017

Sorry, I did that via the github web interface which I assumed would do the right thing. I will fix it up....

@Apteryx0 Apteryx0 force-pushed the (GH-533)UpgradeViaPackagesConfig branch from dbe8ecf to 879778b Compare May 1, 2017 17:56
Implements a subset of the functionality, support for packages.config
files in the upgrade command. Also extended the tests to test the new
code. I did not see any value in implementing package.config support for
uninstall because the problem I am interested in solving is being able
to upgrade multiple packages each with a specific version in one
command. Since uninstall (generally?) doesn't require specifying a
version this can be done on the uninstall command line, i.e. just give
the package list to uninstall.
@Apteryx0 Apteryx0 force-pushed the (GH-533)UpgradeViaPackagesConfig branch from 879778b to 4ef0a40 Compare May 1, 2017 20:26
@EckyZero
Copy link

@Apteryx0 @ferventcoder what's the timeline for getting this merged in? I'm facing a similar use case currently where this feature would make my life easier.

@ferventcoder
Copy link
Member

ferventcoder commented Nov 30, 2017

This has a chance to get into the next version. The linked ticket #533 has the milestone. Currently prioritized in 0.10.9.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Russell Mora seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@gep13 gep13 changed the title (GH-533) Support packages.config file in upgrade (#533) Support packages.config file in upgrade Oct 15, 2021
@gep13 gep13 changed the title (#533) Support packages.config file in upgrade (#3721) Support packages.config file in upgrade Jun 25, 2025
@gep13 gep13 linked an issue Jun 25, 2025 that may be closed by this pull request
2 tasks
@gep13
Copy link
Member

gep13 commented Jun 25, 2025

@Apteryx0 please accept my apologies for the length of time it has taken to get to this milestone. We have recently begun working our way through the backlog of PR's into Chocolatey CLI, and I have been taking a look at this one. We feel that this is a good idea, and it is something that we would like to have available.

I have taken the liberty to create a new issue, rather than linking to the other issue regarding initial support for packages.config file.

This PR will need a little bit of work in order to bring it up to date with the latest code base, but given the length of time that this PR has been open, we can't ask you to work on that, so we will take care of that.

One thing that I would ask is would you be in a position to sign the CLA to allow this code contribution to continue? If not, we will need to recreate the work that you have done here.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support usage of a packages.config for the choco upgrade command Full installation management via packages.config file
5 participants