Migrate operator field from units to inspections #421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the operator (Controller/Owner) field from the units table to the inspections table. This reflects that the operator can change between inspections, making it more appropriate as an inspection-level attribute. Changes: - Add operator column to inspections table - Migrate existing operator values from units to their inspections - Remove operator column from units table - Update models, controllers, helpers, views, and services - Update tests and factories to reflect new data location
Update badge_batches_spec and inspections_csv_completeness_spec to remove operator from unit creation and expectations.
- Add operator text field to inspection form - Add operator to USER_EDITABLE_PARAMS for form submission - Remove operator from unit creation in inspection_unit_selection_spec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the operator (Controller/Owner) field from the units table to the inspections table. This reflects that the operator can change between inspections, making it more appropriate as an inspection-level attribute.
Changes: