-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Scribl to an npm module #35
base: master
Are you sure you want to change the base?
Conversation
I've tested the examples html files, which all work fine. However I'm leaving this as a draft until I have checked that this works correctly when it's imported as a module (as opposed to being used in the global scope, which the examples do) |
of the deleted semicolons
I ended up writing my own visualisation library for this, but I still did a heap of work refactoring Scribl so it might be useful to merge this, if you get a chance to review the massive amount of changes. From my brief testing, it works for all the examples that worked in the original Scribl, and it worked in my React.js tests as well. I can't tell if I haven't broken some edge case, however, because there isn't a unit testing suite. |
I will try to review and merge though it will probably take me some time. Thank for this. |
Great, let me know if you have any questions about the changes I've made. |
Warning, this is quite a large PR:
Int
andFloat
instead ofnumber
)