Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches the
Deg
function inrabinkarp64/polynomials.go
to useLen64
instead of the bit hacks version.On my machine, this does not produce much of a speedup for
go run roll/main.go
but does speed up the rabin karp tests from ~23s to ~6s .Benches
A small difference, but I did an unpaired t-test and it seems to be real.
Command:
Deg
Notes
math/bits
didn't exist until Go 1.9 ( https://pkg.go.dev/math/bits?tab=versions )