Retain productsRequest #48
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…thing needs to be done on a real device.
|
are you sure this is a problem only for loadProducts? my guess is it could happen for purchaseProduct. Not sure if this is the right fix. |
|
It could happen for purchaseProduct on tvOS, but without this fix, loadProducts will silently fail with no response, so we don't have a chance to know what happen next. PS: this fix is for tvOS specifically, iOS just don't need it. |
chirag04
reviewed
Dec 7, 2016
| initWithProductIdentifiers:[NSSet setWithArray:productIdentifiers]]; | ||
| productsRequest.delegate = self; | ||
| _callbacks[RCTKeyForInstance(productsRequest)] = callback; | ||
| [productsRequest start]; |
There was a problem hiding this comment.
this will break when we have multiple requests happening. can you make it a map and in the delegate remove from the map?
gtebbutt
added a commit
to gtebbutt/react-native-in-app-utils
that referenced
this pull request
Nov 27, 2017
Needs improvement; see chirag04#48
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On tvOS, productsRequest got released at end of the loadProducts func, and the following callbacks won't be fired. Declare it as a class level variable fix the problem.