Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix warnings in SD #133

Merged
merged 1 commit into from
Dec 30, 2015
Merged

fix warnings in SD #133

merged 1 commit into from
Dec 30, 2015

Conversation

KeithV
Copy link

@KeithV KeithV commented Dec 30, 2015

Fix SD warnings, also correct change notice in Uno32 and Max32

@chipkitbot
Copy link

Can one of the admins verify this patch?

(Admins, you can respond:

"ok to test" to accept this pull request for testing
"test this please" for a one time test run
"add to whitelist" to add the author to the whitelist
"retest this please" to start a new build after it's already tested once)

@EmbeddedMan
Copy link
Member

ok to test

1 similar comment
@EmbeddedMan
Copy link
Member

ok to test

@chipkitbot
Copy link

The build was successful, and can be seen at http://chipkitjenkins.wayneandlayne.com/job/chipKIT-core%20PR%20Builder/69/.

EmbeddedMan added a commit that referenced this pull request Dec 30, 2015
@EmbeddedMan
Merge pull request #133 from KeithV/master
0095594 
fix warnings in SD
@EmbeddedMan EmbeddedMan merged commit 0095594 into chipKIT32:master Dec 30, 2015
@KeithV
Copy link
Author

KeithV commented Dec 30, 2015

Thanks,

Downloading now and trying!

Happy New Year.

KeithV

From: Brian Schmalz [mailto:[email protected]]
Sent: Wednesday, December 30, 2015 3:28 PM
To: chipKIT32/chipKIT-core
Cc: KeithV
Subject: Re: [chipKIT-core] fix warnings in SD (#133)

Merged #133 #133 .

—
Reply to this email directly or view it on GitHub #133 (comment) . https://github.com/notifications/beacon/AA8RTjpIF6s1K3txlDlanpMjx7TaTQayks5pVGABgaJpZM4G89K_.gif

@KeithV
Copy link
Author

KeithV commented Dec 31, 2015

Adam….. FYI

From: chipKIT Bot [mailto:[email protected]]
Sent: Wednesday, December 30, 2015 1:07 PM
To: chipKIT32/chipKIT-core
Cc: KeithV
Subject: Re: [chipKIT-core] fix warnings in SD (#133)

The build was successful, and can be seen at http://chipkitjenkins.wayneandlayne.com/job/chipKIT-core%20PR%20Builder/69/.

—
Reply to this email directly or view it on GitHub #133 (comment) . https://github.com/notifications/beacon/AA8RTpSzVqW9ITIuzVJiDYXtOJhtFBpvks5pVD76gaJpZM4G89K_.gif

@KeithV
Copy link
Author

KeithV commented Dec 31, 2015

AND….

From: Keith Vogel [mailto:[email protected]]
Sent: Wednesday, December 30, 2015 4:15 PM
To: 'chipKIT32/chipKIT-core'; 'chipKIT32/chipKIT-core'
Cc: Adam Wolf ([email protected]) ([email protected])
Subject: RE: [chipKIT-core] fix warnings in SD (#133)

Adam….. FYI

From: chipKIT Bot [mailto:[email protected]]
Sent: Wednesday, December 30, 2015 1:07 PM
To: chipKIT32/chipKIT-core
Cc: KeithV
Subject: Re: [chipKIT-core] fix warnings in SD (#133)

The build was successful, and can be seen at http://chipkitjenkins.wayneandlayne.com/job/chipKIT-core%20PR%20Builder/69/.

—
Reply to this email directly or view it on GitHub #133 (comment) . https://github.com/notifications/beacon/AA8RTpSzVqW9ITIuzVJiDYXtOJhtFBpvks5pVD76gaJpZM4G89K_.gif

@chipkitbot
Copy link

I wonder if this is related to the file changes Brian's been doing to get
the json loader working on OS X.

On Wed, Dec 30, 2015, 6:19 PM KeithV [email protected] wrote:

AND….

From: Keith Vogel [mailto:[email protected]]
Sent: Wednesday, December 30, 2015 4:15 PM
To: 'chipKIT32/chipKIT-core'; 'chipKIT32/chipKIT-core'
Cc: Adam Wolf ([email protected]) ([email protected])
Subject: RE: [chipKIT-core] fix warnings in SD (#133)

Adam….. FYI

From: chipKIT Bot [mailto:[email protected]]
Sent: Wednesday, December 30, 2015 1:07 PM
To: chipKIT32/chipKIT-core
Cc: KeithV
Subject: Re: [chipKIT-core] fix warnings in SD (#133)

The build was successful, and can be seen at
http://chipkitjenkins.wayneandlayne.com/job/chipKIT-core%20PR%20Builder/69/
.

—
Reply to this email directly or view it on GitHub <
https://github.com/chipKIT32/chipKIT-core/pull/133#issuecomment-168073860>
. <
https://github.com/notifications/beacon/AA8RTpSzVqW9ITIuzVJiDYXtOJhtFBpvks5pVD76gaJpZM4G89K_.gif>

—

Reply to this email directly or view it on GitHub
#133 (comment)
.

@KeithV
Copy link
Author

KeithV commented Dec 31, 2015

However,

It seems to work with the release version of Arduino 1.6.7!

KeithV

From: Keith Vogel [mailto:[email protected]]
Sent: Wednesday, December 30, 2015 4:20 PM
To: 'chipKIT32/chipKIT-core'; 'chipKIT32/chipKIT-core'
Cc: Adam Wolf ([email protected]) ([email protected])
Subject: RE: [chipKIT-core] fix warnings in SD (#133)

AND….

From: Keith Vogel [mailto:[email protected]]
Sent: Wednesday, December 30, 2015 4:15 PM
To: 'chipKIT32/chipKIT-core'; 'chipKIT32/chipKIT-core'
Cc: Adam Wolf ([email protected]) ([email protected])
Subject: RE: [chipKIT-core] fix warnings in SD (#133)

Adam….. FYI

From: chipKIT Bot [mailto:[email protected]]
Sent: Wednesday, December 30, 2015 1:07 PM
To: chipKIT32/chipKIT-core
Cc: KeithV
Subject: Re: [chipKIT-core] fix warnings in SD (#133)

The build was successful, and can be seen at http://chipkitjenkins.wayneandlayne.com/job/chipKIT-core%20PR%20Builder/69/.

—
Reply to this email directly or view it on GitHub #133 (comment) . https://github.com/notifications/beacon/AA8RTpSzVqW9ITIuzVJiDYXtOJhtFBpvks5pVD76gaJpZM4G89K_.gif

@EmbeddedMan
Copy link
Member

EmbeddedMan commented Dec 31, 2015 via email

@KeithV
Copy link
Author

KeithV commented Dec 31, 2015

Well it didn’t seem to hurt anything other than I could not extract it.

Things seem to be working.

KeithV

From: Brian Schmalz [mailto:[email protected]]
Sent: Wednesday, December 30, 2015 4:36 PM
To: chipKIT32/chipKIT-core
Cc: KeithV
Subject: Re: [chipKIT-core] fix warnings in SD (#133)

Yes, the problem of the *.py files in the pic32-tools zip downloads is an
open issue : chipKIT32/chipKIT-cxx#6

I hope this can be resolved pretty soon.

In the meantime, I have created my own versions of the pic32-tools .zip
files and placed them in the v1.0.1 chipKIT-core release. (That don't have
the *.py files in them.)

*Brian

—
Reply to this email directly or view it on GitHub #133 (comment) . https://github.com/notifications/beacon/AA8RTmq9BCxrKz9LuuLhmIUvsGV4Ekw7ks5pVG_7gaJpZM4G89K_.gif

@EmbeddedMan
Copy link
Member

Keith - that's good to hear. In the next couple days, we're going to be
implementing a change to the folder layout when you do a 'manual-copy' of
chipKIT-core. I'll be explaining it in more detail shortly, but it is
required so that we can use the same platform.txt file for both manual and
automatic installs of chipKIT-core. The bottom line is that you'll need to
update chipKIT-core, pic32-tools (the compiler) and pic32prog separately
rather than as one huge download, which has its pros and cons.

*Brian

On Wed, Dec 30, 2015 at 7:07 PM, KeithV [email protected] wrote:

Well it didn’t seem to hurt anything other than I could not extract it.

Things seem to be working.

KeithV

From: Brian Schmalz [mailto:[email protected]]
Sent: Wednesday, December 30, 2015 4:36 PM
To: chipKIT32/chipKIT-core
Cc: KeithV
Subject: Re: [chipKIT-core] fix warnings in SD (#133)

Yes, the problem of the *.py files in the pic32-tools zip downloads is an
open issue : chipKIT32/chipKIT-cxx#6

I hope this can be resolved pretty soon.

In the meantime, I have created my own versions of the pic32-tools .zip
files and placed them in the v1.0.1 chipKIT-core release. (That don't have
the *.py files in them.)

*Brian

—
Reply to this email directly or view it on GitHub <
https://github.com/chipKIT32/chipKIT-core/pull/133#issuecomment-168100266>
. <
https://github.com/notifications/beacon/AA8RTmq9BCxrKz9LuuLhmIUvsGV4Ekw7ks5pVG_7gaJpZM4G89K_.gif>

—
Reply to this email directly or view it on GitHub
#133 (comment)
.

@KeithV
Copy link
Author

KeithV commented Dec 31, 2015

Thanks Brian,

I think I understand as the auto download has links to components, not just one package.

But, with the chipKITBOT, I would think making many different packages would be easy and automatic. We could make the manual install package as well as the auto download packages, no?

KeithV

From: Brian Schmalz [mailto:[email protected]]
Sent: Wednesday, December 30, 2015 6:08 PM
To: chipKIT32/chipKIT-core
Cc: KeithV
Subject: Re: [chipKIT-core] fix warnings in SD (#133)

Keith - that's good to hear. In the next couple days, we're going to be
implementing a change to the folder layout when you do a 'manual-copy' of
chipKIT-core. I'll be explaining it in more detail shortly, but it is
required so that we can use the same platform.txt file for both manual and
automatic installs of chipKIT-core. The bottom line is that you'll need to
update chipKIT-core, pic32-tools (the compiler) and pic32prog separately
rather than as one huge download, which has its pros and cons.

*Brian

On Wed, Dec 30, 2015 at 7:07 PM, KeithV [email protected] wrote:

Well it didn’t seem to hurt anything other than I could not extract it.

Things seem to be working.

KeithV

From: Brian Schmalz [mailto:[email protected]]
Sent: Wednesday, December 30, 2015 4:36 PM
To: chipKIT32/chipKIT-core
Cc: KeithV
Subject: Re: [chipKIT-core] fix warnings in SD (#133)

Yes, the problem of the *.py files in the pic32-tools zip downloads is an
open issue : chipKIT32/chipKIT-cxx#6

I hope this can be resolved pretty soon.

In the meantime, I have created my own versions of the pic32-tools .zip
files and placed them in the v1.0.1 chipKIT-core release. (That don't have
the *.py files in them.)

*Brian

—
Reply to this email directly or view it on GitHub <
https://github.com/chipKIT32/chipKIT-core/pull/133#issuecomment-168100266>
. <
https://github.com/notifications/beacon/AA8RTmq9BCxrKz9LuuLhmIUvsGV4Ekw7ks5pVG_7gaJpZM4G89K_.gif>

—
Reply to this email directly or view it on GitHub
#133 (comment)
.

—
Reply to this email directly or view it on GitHub #133 (comment) . https://github.com/notifications/beacon/AA8RThRTmEaiToarlY21js7cYdGlI-noks5pVIWAgaJpZM4G89K_.gif

@EmbeddedMan
Copy link
Member

Keith,

Unfortunately this would involve either having two separate platform.txt
files (which would be a pain to maintain separately) or would involve some
'build time text substitution magic' which, while absolutely possible,
isn't an added complexity that will help us in the long run. Keeping the
build process as simple as possible will help us I think.

Also, I don't want chipkitbot to be the only place we can build our
outputs. Being able to do it on all of our own machines is super easy right
now, and I'd like to keep it that way if we can.

Now, there is a good opportunity to come up with a simple installer as part
of the build process, which could make the 'manual install process' as
simple as double clicking on a .exe file and having it put everything
(chipkit-core, pic32-tools and pic32prog) in the right places. But that's a
task for another day. ;-)

*Brian

On Thu, Dec 31, 2015 at 11:14 AM, KeithV [email protected] wrote:

Thanks Brian,

I think I understand as the auto download has links to components, not
just one package.

But, with the chipKITBOT, I would think making many different packages
would be easy and automatic. We could make the manual install package as
well as the auto download packages, no?

KeithV

From: Brian Schmalz [mailto:[email protected]]
Sent: Wednesday, December 30, 2015 6:08 PM

To: chipKIT32/chipKIT-core
Cc: KeithV
Subject: Re: [chipKIT-core] fix warnings in SD (#133)

Keith - that's good to hear. In the next couple days, we're going to be
implementing a change to the folder layout when you do a 'manual-copy' of
chipKIT-core. I'll be explaining it in more detail shortly, but it is
required so that we can use the same platform.txt file for both manual and
automatic installs of chipKIT-core. The bottom line is that you'll need to
update chipKIT-core, pic32-tools (the compiler) and pic32prog separately
rather than as one huge download, which has its pros and cons.

*Brian

On Wed, Dec 30, 2015 at 7:07 PM, KeithV [email protected] wrote:

Well it didn’t seem to hurt anything other than I could not extract it.

Things seem to be working.

KeithV

From: Brian Schmalz [mailto:[email protected]]
Sent: Wednesday, December 30, 2015 4:36 PM
To: chipKIT32/chipKIT-core
Cc: KeithV
Subject: Re: [chipKIT-core] fix warnings in SD (#133)

Yes, the problem of the *.py files in the pic32-tools zip downloads is an
open issue : chipKIT32/chipKIT-cxx#6

I hope this can be resolved pretty soon.

In the meantime, I have created my own versions of the pic32-tools .zip
files and placed them in the v1.0.1 chipKIT-core release. (That don't
have
the *.py files in them.)

*Brian

—
Reply to this email directly or view it on GitHub <

https://github.com/chipKIT32/chipKIT-core/pull/133#issuecomment-168100266>
. <

https://github.com/notifications/beacon/AA8RTmq9BCxrKz9LuuLhmIUvsGV4Ekw7ks5pVG_7gaJpZM4G89K_.gif

—
Reply to this email directly or view it on GitHub
<
https://github.com/chipKIT32/chipKIT-core/pull/133#issuecomment-168102376>
.

—
Reply to this email directly or view it on GitHub <
https://github.com/chipKIT32/chipKIT-core/pull/133#issuecomment-168110551>
. <
https://github.com/notifications/beacon/AA8RThRTmEaiToarlY21js7cYdGlI-noks5pVIWAgaJpZM4G89K_.gif>

—
Reply to this email directly or view it on GitHub
#133 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KeithV @chipkitbot @EmbeddedMan