Unit Test for DHCP (FreeRTOS#902)

* 100% coverage for DHCP * Fix multiple redefinition issue * Fix spell check error * fix spelling * Fix 100% coverage for DNS_cache and DNS_Parser * Add workflow for coverage check * Fix Format issue * Fix source code * Add test case for Malformed packet in xProcessCheckOption
chinglee-iot · Jun 9, 2023 · 9e525be · 9e525be
1 parent 2ece7fe
commit 9e525be
Show file tree

Hide file tree

Showing 7 changed files with 2,651 additions and 793 deletions.
diff --git a/.github/lexicon.txt b/.github/lexicon.txt
@@ -185,6 +185,7 @@ dff
 dhcp
 dhcpbroadcast
 dhcpcookie
+dhcpmsg
 dhcpserveraddress
 didn
 diff
@@ -552,6 +553,7 @@ macobject
 macobjhandle
 macobjstatus
 macvlantr
+malformed
 malloc
 malloclarge
 mallocsocket
@@ -1410,6 +1412,7 @@ ulflag
 ulflags
 ulgateway
 ulgatewayaddress
+ulgenericlength
 ulgetruntimecountervalue
 ulhighestrxallowed
 ulhighestsequencenumber

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -34,10 +34,10 @@ jobs:
         run: |
           make -C test/unit-test/build/ coverage
           lcov --list --rc lcov_branch_coverage=1 test/unit-test/build/coverage.info
-      # - name: Check Coverage
-      #   uses: FreeRTOS/CI-CD-Github-Actions/coverage-cop@main
-      #   with:
-      #     path: ./test/unit-test/build/coverage.info
+      - name: Check Coverage
+        uses: FreeRTOS/CI-CD-Github-Actions/coverage-cop@main
+        with:
+          path: ./test/unit-test/build/coverage.info
 
   spell-check:
     runs-on: ubuntu-latest

diff --git a/source/FreeRTOS_DHCP.c b/source/FreeRTOS_DHCP.c
@@ -889,7 +889,6 @@
                 /* Bind to the standard DHCP client port. */
                 xAddress.sin_port = ( uint16_t ) dhcpCLIENT_PORT_IPv4;
                 xReturn = vSocketBind( xDHCPv4Socket, &xAddress, sizeof( xAddress ), pdFALSE );
-                configASSERT( xReturn == 0 );
                 xDHCPSocketUserCount = 1;
                 FreeRTOS_printf( ( "DHCP-socket[%02x-%02x]: DHCP Socket Create\n",
                                    pxEndPoint->xMACAddress.ucBytes[ 4 ],
@@ -1043,11 +1042,7 @@
                         {
                             EP_IPv4_SETTINGS.ulDNSServerAddresses[ uxTargetIndex ] = pxSet->ulParameter;
                             uxTargetIndex++;
-
-                            if( uxTargetIndex >= ipconfigENDPOINT_DNS_ADDRESS_COUNT )
-                            {
-                                break;
-                            }
+                            /* uxDNSCount <= ipconfigENDPOINT_DNS_ADDRESS_COUNT , hence check is removed. */
                         }
 
                         uxByteIndex += sizeof( uint32_t );

diff --git a/test/unit-test/ConfigFiles/FreeRTOSIPConfig.h b/test/unit-test/ConfigFiles/FreeRTOSIPConfig.h
@@ -84,7 +84,7 @@
  * a socket.
  */
 #define ipconfigUSE_DNS_CACHE                      ( 1 )
-#define ipconfigDNS_CACHE_ADDRESSES_PER_ENTRY      ( 2 )
+#define ipconfigDNS_CACHE_ADDRESSES_PER_ENTRY      ( 1 )
 #define ipconfigDNS_REQUEST_ATTEMPTS               ( 2 )
 
 #define ipconfigDNS_CACHE_NAME_LENGTH              ( 254 )