Skip to content

Conversation

@aDifferentJT
Copy link
Contributor

This fixes #335 by adding the missing newline

@aDifferentJT aDifferentJT mentioned this pull request Oct 10, 2025
@chinedufn
Copy link
Owner

chinedufn commented Oct 11, 2025

Please add a #[swift_bridge(Copy(4), Sendable)] type to crates/swift-integration-tests.
Can put documentation on the type explaining why we added the test type (i.e. basically that our codegen was missing a newline so adding this type ensures that our codegen is now working).
Don't have to call the type from the Swift side. Just defining it it crates/swift-integration-tests should be enough of a test case here.

Generally we don't land code without also adding a test that would have failed before the code was added.

Let me know if you'd like me to write up a guide on how to add this test.
Seems like you already have a good sense of where things are so I won't put effort into a guide unless you ask.

Also, same feedback as #339 (review) just need to update the PR title and body with more info (you can still also link to the issue #335 ).

After that this looks good. Thanks for the detailed report and for submitting a fix.

@chinedufn chinedufn changed the title FIXES #335 Fix using multiple Copy + Sendable types Oct 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Multiple types that are both Copy and Sendable creates a swift file missing a newline

2 participants