Fixed parsing for empty strings in lists getting dropped #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed token list parsing for empty strings in token list.
|
Testing results:
|
davlee1972
changed the title
|
There should be error checking for invalid ",," in hocon lists, but that is a different issue. Right now those will be just be included as additional empty strings in a list.
https://getakka.net/articles/configuration/hocon.html [1,2,3,,] is invalid because it has two trailing commas. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced block of code skipping empty strings in lists with:
New block of code that pops empty string values in the first item and last item of a token list if that token list was generated from a multiline list. All other empty string values in lists are preserved and not dropped..
Fixes:
#232
Related Issue:
#317