Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduced a utility function 'spliceArray' to be used instead of #55

Closed
wants to merge 1 commit into from

Conversation

asheshv
Copy link
Contributor

@asheshv asheshv commented Dec 12, 2019

'Array.prototype.splice', which results into an error -
"Maximum call stack size exceeded" when working with very big arrays.

Modified the given probable fix little bit to avoid replacing some elements repetitively.

Reported By: https://github.com/YeskaNova
fixes #51

'Array.prototype.splice', which results into an error -
"Maximum call stack size exceeded" when working with very big arrays.

Reported By: https://github.com/YeskaNova
Issue cheton#51
@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 67.595% when pulling b09991b on asheshv:ARRAY_SPLICE into 7bf037e on cheton:master.

@cheton cheton closed this Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Splice.Apply causes “Maximum call stack size exceeded” when there is 170k+ nodes under one node
3 participants