Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for directly requiring css from node modules without #72

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pavan142
Copy link

@pavan142 pavan142 commented Mar 1, 2021

prefixing with "../node_modules"

Instead of requring @import "../node_modules/bootstrap/dist/css/bootstrap.css";
now it can be required as @import "bootstrap/dist/css/bootstrap.css";

Used https://github.com/browserify/resolve to implement this

Signed-off-by: pavan142 [email protected]

 prefixing with "../node_modules"

Signed-off-by: pavan142 <[email protected]>
@coveralls
Copy link

Coverage Status

Coverage increased (+0.7%) to 82.326% when pulling 6eb0835 on pavan142:implicitNodeModuleSupport into 824ac41 on cheton:master.

@pavan142
Copy link
Author

pavan142 commented Mar 1, 2021

Hi, the travis ci build is failing for Node.js version 6. To debug, I have checked Travis CI build on the latest master branch, and the build is failing even with current baseline. Can some one help me override this ?

npm ERR! Linux 4.4.0-104-generic
npm ERR! argv "/home/travis/.nvm/versions/node/v6.17.1/bin/node" "/home/travis/.nvm/versions/node/v6.17.1/bin/npm" "install" "-g" "npm"
npm ERR! node v6.17.1
npm ERR! npm  v3.10.10
npm ERR! path /home/travis/.nvm/versions/node/v6.17.1/lib/node_modules/.staging/@npmcli/ci-detect-ccabb611
npm ERR! code ENOENT
npm ERR! errno -2
npm ERR! syscall rename
npm ERR! enoent ENOENT: no such file or directory, rename '/home/travis/.nvm/versions/node/v6.17.1/lib/node_modules/.staging/@npmcli/ci-detect-ccabb611' -> '/home/travis/.nvm/versions/node/v6.17.1/lib/node_modules/npm/node_modules/@npmcli/ci-detect'
npm ERR! enoent ENOENT: no such file or directory, rename '/home/travis/.nvm/versions/node/v6.17.1/lib/node_modules/.staging/@npmcli/ci-detect-ccabb611' -> '/home/travis/.nvm/versions/node/v6.17.1/lib/node_modules/npm/node_modules/@npmcli/ci-detect'
npm ERR! enoent This is most likely not a problem with npm itself
npm ERR! enoent and is related to npm not being able to find a file.
npm ERR! enoent 
npm ERR! Please include the following file with any support request:
npm ERR!     /home/travis/build/cheton/browserify-css/npm-debug.log
npm ERR! code 1
The command "npm install -g npm" failed and exited with 1 during .
Your build has been stopped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants