Skip to content

Commit

Permalink
refact: add logger
Browse files Browse the repository at this point in the history
  • Loading branch information
chetat committed May 19, 2023
1 parent e4e1c35 commit 39ca6f0
Show file tree
Hide file tree
Showing 4 changed files with 46 additions and 10 deletions.
30 changes: 20 additions & 10 deletions app/api/v1/users/auth.py
Original file line number Diff line number Diff line change
@@ -1,26 +1,36 @@
from fastapi import APIRouter, Depends
from fastapi import APIRouter, Depends, status, HTTPException
from sqlalchemy.orm import Session
from app.core.database import get_session
from app.schemas.users import UserRequest
from app.services import users as user_service
from app.logger.kaolog import get_logger

logger = get_logger(__name__)
router = APIRouter()


# Note: Why choose int over str for user_id?
@router.get("/login")
async def authenticate_user(user_id: str, session: Session = Depends(get_session)):
return {"message": f"Hello {user_id}"}


@router.post("")
async def create_user(
user_request: UserRequest, session: Session = Depends(get_session)
):
password = user_request.password
user_request_dict = user_request.dict(exclude={"password"})
user_service.create_user(session, password, user_request_dict)
return {"message": "User created"}
try:
user_service.create_user(session, password, user_request_dict)
return {"message": "User created"}
except Exception as e:
logger.error(e)
raise HTTPException(
status_code=status.HTTP_500_INTERNAL_SERVER_ERROR,
detail={
"message": "Something went wrong when creating user",
}
)


@router.get("/access-token")
async def authenticate_user(user_id: str, session: Session = Depends(get_session)):
return {"message": f"Hello {user_id}"}



@router.post("/logout")
Expand Down
Empty file added app/logger/__init__.py
Empty file.
25 changes: 25 additions & 0 deletions app/logger/kaolog.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
import logging
import json

class JsonFormatter(logging.Formatter):
def format(self, record):
log_object = {
'level': record.levelname,
'message': record.getMessage(),
'time': self.formatTime(record),
'source': record.pathname,
'line': record.lineno,
'function': record.funcName
}
return json.dumps(log_object)


def get_logger(name):
logger = logging.getLogger(__name__)
logger.setLevel(logging.INFO)

handler = logging.StreamHandler()
handler.setFormatter(JsonFormatter())

logger.addHandler(handler)
return logger
1 change: 1 addition & 0 deletions app/services/users.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ def create_user(session: Session, password, user_info: Dict[str, Any]):
user_repo.add_user(session, user_info)
session.commit()


def get_user_by_id(user_id: str):
return {"message": f"Hello {user_id}"}

Expand Down

0 comments on commit 39ca6f0

Please sign in to comment.