Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Migrate resource metadata from contentStream to contentMetadata [DEV-4767] #348

Merged
merged 9 commits into from
Feb 25, 2025
Merged

fix: Migrate resource metadata from contentStream to contentMetadata [DEV-4767] #348

merged 9 commits into from
Feb 25, 2025

Conversation

DaevMithran
Copy link
Contributor

@DaevMithran DaevMithran commented Feb 25, 2025 •
edited
Loading

  • Move contentStream to contentMetadata for linkedResourceMetadata queries
  • Naive solution to support browser resolutions
  • Errors return in json on RepresentationNotSupported error

@DaevMithran DaevMithran mentioned this pull request Feb 25, 2025
Closed
@DaevMithran DaevMithran force-pushed the fix-contentstream-metadata branch from aee3b30 to 8fdc566 Compare February 25, 2025 09:37
@DaevMithran DaevMithran requested review from ankurdotb and sownak and removed request for ankurdotb February 25, 2025 10:09
@ankurdotb ankurdotb changed the title feat: Migrate resource metadata from contentStream to contentMetadata fix: Migrate resource metadata from contentStream to contentMetadata [DEV-4767] Feb 25, 2025
@ankurdotb
Copy link
Contributor

Task linked: DEV-4767 Move metadata consistently from contentStream to contentMetadata

ankurdotb
ankurdotb reviewed Feb 25, 2025
View reviewed changes
Copy link
Contributor

@ankurdotb ankurdotb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this fine...as long as @sownak is happy with it AND we handle matching response type to accept header correctly, which will eliminate the need to check for the user agent string, which can/should be removed.

@sownak sownak merged commit 43c05d7 into develop Feb 25, 2025
18 checks passed
@sownak sownak deleted the fix-contentstream-metadata branch February 25, 2025 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankurdotb ankurdotb ankurdotb left review comments

@sownak sownak sownak approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DaevMithran @ankurdotb @sownak