Add unit tests

Author: chenzhaiyu

.github/workflows/tests.yml

@@ -27,12 +27,91 @@ jobs:
         run: |
           conda activate abspy
           pip install --upgrade .
+      
+      - name: Install pytest
+        shell: bash -l {0}
+        run: |
+          conda activate abspy
+          pip install pytest
+
+      - name: Run unit tests
+        shell: bash -l {0}
+        run: |
+          conda activate abspy
+          pytest tests/ -v
+
+      - name: Run tutorial_complex.py
+        continue-on-error: true
+        id: tutorial_complex
+        shell: bash -l {0}
+        run: |
+          conda activate abspy
+          echo "Running tutorial_complex.py..."
+          python tutorials/tutorial_complex.py
 
-      - name: Run tests
+      - name: Run tutorial_primitive.py
+        continue-on-error: true
+        id: tutorial_primitive
         shell: bash -l {0}
         run: |
           conda activate abspy
-          python tests/test_complex.py
-          python tests/test_primitive.py
-          python tests/test_graph.py
-          python tests/test_combined.py
+          echo "Running tutorial_primitive.py..."
+          python tutorials/tutorial_primitive.py
+
+      - name: Run tutorial_graph.py
+        continue-on-error: true
+        id: tutorial_graph
+        shell: bash -l {0}
+        run: |
+          conda activate abspy
+          echo "Running tutorial_graph.py..."
+          python tutorials/tutorial_graph.py
+
+      - name: Run tutorial_combined.py
+        continue-on-error: true
+        id: tutorial_combined
+        shell: bash -l {0}
+        run: |
+          conda activate abspy
+          echo "Running tutorial_combined.py..."
+          python tutorials/tutorial_combined.py
+
+      - name: Check tutorial execution status
+        shell: bash -l {0}
+        run: |
+          echo "Checking tutorial execution results:"
+          
+          if [ "${{ steps.tutorial_complex.outcome }}" == "success" ]; then
+            echo "✅ tutorial_complex.py executed successfully"
+          else
+            echo "❌ tutorial_complex.py failed"
+            exit_code=1
+          fi
+          
+          if [ "${{ steps.tutorial_primitive.outcome }}" == "success" ]; then
+            echo "✅ tutorial_primitive.py executed successfully"
+          else
+            echo "❌ tutorial_primitive.py failed"
+            exit_code=1
+          fi
+          
+          if [ "${{ steps.tutorial_graph.outcome }}" == "success" ]; then
+            echo "✅ tutorial_graph.py executed successfully"
+          else
+            echo "❌ tutorial_graph.py failed"
+            exit_code=1
+          fi
+          
+          if [ "${{ steps.tutorial_combined.outcome }}" == "success" ]; then
+            echo "✅ tutorial_combined.py executed successfully"
+          else
+            echo "❌ tutorial_combined.py failed"
+            exit_code=1
+          fi
+          
+          if [ -n "$exit_code" ]; then
+            echo "One or more tutorials failed. Check the logs above for details."
+            exit 1
+          else
+            echo "All tutorials executed successfully!"
+          fi

.gitignore

@@ -130,7 +130,9 @@ dmypy.json
 # Pycharm
 .idea/
 
-# data and output
-tests/test_data/
-tests/test_output/
+# Visual Studio Code
+.vscode/
 
+# data and output
+data/
+output/

CHANGELOG.md

@@ -6,6 +6,14 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 ### Added
+- Unit tests integrated with GitHub Actions workflow.
+
+### Changed
+- Rename previous `tests` to `tutorials`.
+- `CellComplex.prioritise_planes` defaults `prioritise_verticals=False`.
+
+## [0.2.6] - 2025-02-03
+### Added
 - `engine='mesh'` for `AdjacencyGraph.save_surface_obj` for mesh output (https://github.com/chenzhaiyu/abspy/issues/18).
 - `.github/workflows/tests.yml`
 - `CONTRIBUTING.md`

abspy/complex.py

@@ -97,7 +97,8 @@ def __init__(self, planes, aabbs, obbs=None, points=None, initial_bound=None, in
         # missing planes due to occlusion or incapacity of RANSAC
         self.additional_planes = additional_planes
 
-        self.initial_bound = initial_bound if initial_bound else self._pad_bound(
+        # Fix: Use explicit None check instead of boolean evaluation which is ambiguous for arrays
+        self.initial_bound = initial_bound if initial_bound is not None else self._pad_bound(
             [np.amin(aabbs[:, 0, :], axis=0), np.amax(aabbs[:, 1, :], axis=0)],
             padding=initial_padding)
         self.cells = [self._construct_initial_cell()]  # list of QQ
@@ -152,7 +153,7 @@ def refine_planes(self, theta=10 * 3.1416 / 180, epsilon=0.005, normalise_normal
         # shallow copy of the primitives
         planes = list(copy(self.planes))
         aabbs = list(copy(self.aabbs))
-        obbs = list(copy(self.obbs))
+        obbs = list(copy(self.obbs)) if self.obbs is not None else []
         points = list(copy(self.points))
 
         # pre-compute cosine of theta
@@ -224,7 +225,7 @@ def refine_planes(self, theta=10 * 3.1416 / 180, epsilon=0.005, normalise_normal
         self.obbs = np.array(obbs)
         self.points = np.array(points, dtype=object)
 
-    def prioritise_planes(self, prioritise_verticals=True):
+    def prioritise_planes(self, prioritise_verticals=False):
         """
         Prioritise certain planes to favour building reconstruction.