Feature/py3.13 #26
Open
Feature/py3.13 #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
decaz
suggested changes
Oct 15, 2024
setup.py
Outdated
| description="High performance Trie and Ahocorasick automata (AC automata) for python", | ||
| name="cyac", | ||
| url="https://github.com/nppoly/cyac", | ||
| author="nppoly", | ||
| author_email="[email protected]", | ||
| packages=["cyac"], | ||
| package_dir={'cyac': 'lib/cyac'}, | ||
| package_data={'cyac': ['*.pxd', 'cyac/unicode_portability.c']}, | ||
| package_data={'cyac': ['*.pxd', 'cyac/unicode_portability.c', 'cyac/unicodectype_db.h']}, |
There was a problem hiding this comment.
Mistype: "unicodetype_db.h" (without "c" between "unicode" and "type").
There was a problem hiding this comment.
new version is uploaded
There was a problem hiding this comment.
if you are using this library in product env, please also do some perf, if there are any bottlenecks. I'm happy to optimize it.
There was a problem hiding this comment.
@chenkovsky thank you! First I'll try it on CPython 3.12, because not all dependencies which I'm using in production environment are compatible with CPython 3.13 now. When I could update to version 3.13 I'll give you feedback here about usage in production.
chenkovsky
force-pushed
the
feature/py3.13
branch
from
2516596 to
55f1ba7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.