Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: floating publication string over spectrum #3364

Merged
merged 4 commits into from
Feb 24, 2025

Conversation

hamed-musallam
Copy link
Member

No description provided.

@hamed-musallam hamed-musallam linked an issue Feb 19, 2025 that may be closed by this pull request
Copy link

cloudflare-workers-and-pages bot commented Feb 19, 2025

Deploying nmrium with  Cloudflare Pages  Cloudflare Pages

Latest commit: a4a1389
Status: ✅  Deploy successful!
Preview URL: https://15db0132.nmrium.pages.dev
Branch Preview URL: https://display-assignment-on-the-sp.nmrium.pages.dev

View logs

@hamed-musallam hamed-musallam force-pushed the display-assignment-on-the-spectrum branch from f33def1 to 269b1b6 Compare February 19, 2025 11:55
Copy link

Deploying nmrium with  Cloudflare Pages  Cloudflare Pages

Latest commit: 7317330
Status: ✅  Deploy successful!
Preview URL: https://c070b608.nmrium.pages.dev
Branch Preview URL: https://display-assignment-on-the-sp.nmrium.pages.dev

View logs

@hamed-musallam hamed-musallam force-pushed the display-assignment-on-the-spectrum branch 4 times, most recently from 314fbfe to ad1c822 Compare February 24, 2025 09:56
refactor: change bounding action
feat: enhance svg table styling and auto row spanning

- Implement automatic row spanning
- Improve column styling
- Enhance SVG table properties
@hamed-musallam hamed-musallam force-pushed the display-assignment-on-the-spectrum branch from ad1c822 to 840ba4e Compare February 24, 2025 10:09
@hamed-musallam hamed-musallam force-pushed the display-assignment-on-the-spectrum branch from 284fde3 to a4a1389 Compare February 24, 2025 11:20
@hamed-musallam
Copy link
Member Author

hamed-musallam commented Feb 24, 2025

The code still needs improvement:
1. Refacto: display the floating publication string and ranges over the spectrum, creating a common component for both.
2. Implement scaling for the SVG table.

@hamed-musallam hamed-musallam merged commit 552fadd into main Feb 24, 2025
10 checks passed
@hamed-musallam hamed-musallam deleted the display-assignment-on-the-spectrum branch February 24, 2025 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display assignment on the spectrum
1 participant