Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: spectra colors customization and show/hide the values of integrals #2819

Merged
merged 5 commits into from
Jan 11, 2024

Conversation

hamed-musallam
Copy link
Member

No description provided.

@hamed-musallam hamed-musallam linked an issue Jan 9, 2024 that may be closed by this pull request
Copy link

cloudflare-workers-and-pages bot commented Jan 9, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 508ea83
Status: ✅  Deploy successful!
Preview URL: https://6107cd00.nmrium.pages.dev
Branch Preview URL: https://spectra-colors-customization.nmrium.pages.dev

View logs

Copy link

codecov bot commented Jan 9, 2024

Codecov Report

Attention: 554 lines in your changes are missing coverage. Please review.

Comparison is base (12d03b8) 2.19% compared to head (508ea83) 2.28%.
Report is 2 commits behind head on main.

Files Patch % Lines
.../setting/settings-tabs/SpectraColorsTabContent.tsx 0.00% 257 Missing and 1 partial ⚠️
src/data/utilities/getCustomColor.ts 31.74% 43 Missing ⚠️
...component/workspaces/workspaceDefaultProperties.ts 0.00% 41 Missing ⚠️
.../component/panels/IntegralsPanel/IntegralPanel.tsx 0.00% 29 Missing ⚠️
...nent/elements/formik/FormikColorPickerDropdown.tsx 0.00% 27 Missing and 1 partial ⚠️
src/component/reducer/actions/IntegralsActions.ts 0.00% 28 Missing ⚠️
src/component/panels/RangesPanel/RangesHeader.tsx 0.00% 22 Missing ⚠️
src/component/reducer/actions/LoadActions.ts 0.00% 19 Missing ⚠️
src/component/modal/setting/settingsValidation.ts 0.00% 16 Missing ⚠️
src/data/PredictionManager.ts 0.00% 16 Missing ⚠️
... and 13 more
Additional details and impacted files
@@           Coverage Diff            @@
##            main   #2819      +/-   ##
========================================
+ Coverage   2.19%   2.28%   +0.08%     
========================================
  Files        639     641       +2     
  Lines      62469   63015     +546     
  Branches     690     695       +5     
========================================
+ Hits        1369    1437      +68     
- Misses     60512   60989     +477     
- Partials     588     589       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hamed-musallam hamed-musallam force-pushed the spectra-colors-customization branch from 152a85b to 82c9575 Compare January 10, 2024 12:43
@hamed-musallam hamed-musallam force-pushed the spectra-colors-customization branch 2 times, most recently from aa8f01f to 3172e20 Compare January 10, 2024 14:40
@hamed-musallam hamed-musallam changed the title feat: spectra colors customization feat: spectra colors customization and show/hide the values of integrals Jan 10, 2024
@hamed-musallam hamed-musallam marked this pull request as ready for review January 10, 2024 14:41
@hamed-musallam hamed-musallam linked an issue Jan 10, 2024 that may be closed by this pull request
@hamed-musallam hamed-musallam force-pushed the spectra-colors-customization branch 3 times, most recently from ff0da43 to 41d65e0 Compare January 11, 2024 09:57
@hamed-musallam hamed-musallam force-pushed the spectra-colors-customization branch from 3b83a42 to 508ea83 Compare January 11, 2024 10:48
@hamed-musallam hamed-musallam merged commit f2a0ce3 into main Jan 11, 2024
13 checks passed
@hamed-musallam hamed-musallam deleted the spectra-colors-customization branch January 11, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add toggle button to remove integration Customization of spectra colors in workspace / general settings
1 participant