Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ms-spectrum): export fromMonoisotopicMass #260

Merged
merged 2 commits into from
Dec 22, 2024
Merged

Conversation

tpoisseau
Copy link
Collaborator

moved from emdb package to remove circular dependency between emdb and ms-spectrum

it was internal, method was accessible through EMDB.prototype.fromMonoisotopicMass

Closes: #70

moved from `emdb` package to remove circular dependency between `emdb` and `ms-spectrum`

it was internal, method was accessible through `EMDB.prototype.fromMonoisotopicMass`

Closes: #70
@tpoisseau tpoisseau linked an issue Dec 20, 2024 that may be closed by this pull request
2 tasks
@tpoisseau tpoisseau requested review from targos and lpatiny December 20, 2024 08:25
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.56%. Comparing base (629973d) to head (ed25162).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #260      +/-   ##
==========================================
+ Coverage   96.55%   96.56%   +0.01%     
==========================================
  Files         213      213              
  Lines       19783    19785       +2     
  Branches     2245     2245              
==========================================
+ Hits        19101    19105       +4     
+ Misses        674      672       -2     
  Partials        8        8              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@targos targos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM. @lpatiny Please review the test case expectations.

@tpoisseau
Copy link
Collaborator Author

I kept tests from emdb as is. (it test fromMonoisotopicMass) from EMDB.prototype.fromMonoisotopicMass method.

And I replicate fromMonoisotopicMass.test.js into ms-spectrum. Same tests, but directly with fromMonoisotopicMass function.

@lpatiny lpatiny merged commit dd8d2a4 into main Dec 22, 2024
10 checks passed
@lpatiny lpatiny deleted the 70-dependency-cycle branch December 22, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dependency cycle
3 participants