[chef-client] Enable chef-client scheduled task to behave like cron, … #739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gholtiii
force-pushed
the
gh/add_cron_parity_to_scheduled_task
branch
from
de1a842
to
361b86e
Compare
gholtiii
force-pushed
the
gh/add_cron_parity_to_scheduled_task
branch
12 times, most recently
from
bd7fbaf
to
4cd29c2
Compare
resources/scheduled_task.rb
Outdated
| @@ -17,9 +17,10 @@ | |||
| # limitations under the License. | |||
| # | |||
|
|
|||
| chef_version_for_provides '< 16.0' if respond_to?(:chef_version_for_provides) | |||
| chef_version_for_provides '< 18.0' if respond_to?(:chef_version_for_provides) | |||
There was a problem hiding this comment.
@gholtiii this was added so that the resource shipped in the core of chef infra client would be used over this resource.
https://github.com/chef/chef/blob/master/lib/chef/resource/chef_client_scheduled_task.rb
In other words, these changes should be made in https://github.com/chef/chef
There was a problem hiding this comment.
Submitted to the core chef/chef#11894
I'll fix this version constraint and resubmit, though it seems this cookbook should be deprecated given the above.
gholtiii
force-pushed
the
gh/add_cron_parity_to_scheduled_task
branch
6 times, most recently
from
6ebfe1f
to
7890004
Compare
…with predictable splay and start time Signed-off-by: George Holt <[email protected]>
gholtiii
force-pushed
the
gh/add_cron_parity_to_scheduled_task
branch
from
7890004
to
87affb5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make chef-client scheduled task behave like cron, with a predictable start time and splay that stays consistent for a given node
Description
The chef-client windows scheduled task uses a random delay that can be up to 25 minutes and a start time based on when the code actually runs. Instead this change is meant to make the start time predictable, similar to a cron entry like */30, and the splay is used to compute a distinct per node value identical to how it's being done on cron (splay_sleep_time method). This enables the next actual start time for a chef run to be predictable for a given node.
Issues Resolved
Check List