Get most test kitchen tests passing in Travis #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clintoncwolfe
changed the title
clintoncwolfe
added
the
Aspect: Testing
tas50
reviewed
Dec 17, 2019
libraries/matchers.rb
Outdated
| @@ -1,12 +1,3 @@ | |||
| # encoding: utf-8 | |||
|
|
|||
| # used by ChefSpec | |||
There was a problem hiding this comment.
This whole file should just get removed now that it's empty
tas50
reviewed
Dec 17, 2019
.travis.yml
Outdated
| - CHEF_VERSION=15 | ||
| - KITCHEN_YAML=kitchen.dokken.yml | ||
| - CHEF_LICENSE="accept-no-persist" | ||
|
|
||
| before_install: | ||
| - sudo iptables -L DOCKER || ( echo "DOCKER iptables chain missing" ; sudo iptables -N DOCKER ) | ||
| - CHEF_LICENSE="accept-no-persist" sudo chef gem install webmock | ||
| - eval "$(chef shell-init bash)" | ||
| - chef --version | ||
| - cookstyle --version |
There was a problem hiding this comment.
chef --version should include all the version output you need. It includes cookstyle and kitchen and foodcritic is dead.
tas50
reviewed
Dec 17, 2019
.travis.yml
Outdated
| @@ -43,24 +51,27 @@ matrix: | |||
| - rvm: 2.6.3 | |||
There was a problem hiding this comment.
These should probably get updated to 2.6.5 while you're in here to match chef
Signed-off-by: Clinton Wolfe <[email protected]>
Signed-off-by: Clinton Wolfe <[email protected]>
Signed-off-by: Clinton Wolfe <[email protected]>
Signed-off-by: Clinton Wolfe <[email protected]>
Signed-off-by: Clinton Wolfe <[email protected]>
Update tests to pass travs Signed-off-by: Alex Pop <[email protected]>
|
Gents, I pused a commit that clears all the outstanding travis errors. |
vjeffrey
approved these changes
Mar 2, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was mainly about updating which Kitchenfile was to be used, and the fact that we now need to accept a license.
Along the way, one set of suites (5) was discovered to be badly broken due to an inspec bug (the naming collision around the
gemresource). I opened an issue (#406) and commented out those suites for now.Finally, the tests won't turn green yet because the codebase fails linting. I opened #407 to track that. I can fix that on this PR if desired.Fixes #407, partially addresses #403