Merge pull request #410 from jugglinmike/replacewith-args

Correct arguments for 'replaceWith' callback
cheeriojs · Mar 6, 2014 · 6ce5473 · 6ce5473
2 parents aa0cc40 + 380663e
commit 6ce5473
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/lib/api/manipulation.js b/lib/api/manipulation.js
@@ -165,7 +165,7 @@ var replaceWith = exports.replaceWith = function(content) {
         index;
 
     if (_.isFunction(content)) {
-      dom = makeDomArray(content.call(el, i));
+      dom = makeDomArray(content.call(el, i, el));
     }
 
     // In the case that `dom` contains nodes that already exist in other

diff --git a/test/api.manipulation.js b/test/api.manipulation.js
@@ -595,7 +595,11 @@ describe('$(...)', function() {
         return '<li class="first">';
       });
 
-      expect(args).to.eql([[0], [1], [2]]);
+      expect(args).to.eql([
+        [0, origChildren[0]],
+        [1, origChildren[1]],
+        [2, origChildren[2]]
+      ]);
       expect(thisValues).to.eql([
         origChildren[0],
         origChildren[1],