Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #522: update checkstyle to 10.17.0 #524

Merged
merged 1 commit into from
May 28, 2024
Merged

Issue #522: update checkstyle to 10.17.0 #524

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ Compatibility matrix from Checkstyle:

| Checkstyle Plugin | Sonar min | Sonar max | Checkstyle | Jdk |
|-------------------|-----------|-----------|------------|-----|
| 10.17.0 | 9.9 | 10.0+ | 10.17.0 | 11 |
| 10.16.0 | 9.9 | 10.0+ | 10.16.0 | 11 |
| 10.15.0 | 9.9 | 10.0+ | 10.15.0 | 11 |
| 10.14.2 | 9.9 | 10.0+ | 10.14.2 | 11 |
Expand Down
4 changes: 2 additions & 2 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,13 +93,13 @@
</ciManagement>

<properties>
<checkstyle.version>10.16.0</checkstyle.version>
<checkstyle.version>10.17.0</checkstyle.version>
<sonar.version>9.9.4.87374</sonar.version>
<sonar.api-version>9.9.0.229</sonar.api-version>
<maven.sevntu.checkstyle.plugin.version>1.44.1</maven.sevntu.checkstyle.plugin.version>
<!-- it should be a version of checkstyle that is compatible/compiled with sevntu -->
<maven.sevntu.checkstyle.plugin.checkstyle.version>
10.16.0
10.17.0
</maven.sevntu.checkstyle.plugin.checkstyle.version>
<antrun.plugin.version>3.1.0</antrun.plugin.version>
<checkstyle.configLocation>https://raw.githubusercontent.com/checkstyle/checkstyle/checkstyle-${checkstyle.version}/config/checkstyle-checks.xml</checkstyle.configLocation>
Expand Down
2 changes: 1 addition & 1 deletion src/test/java/org/sonar/plugins/checkstyle/CheckstyleRulesDefinitionTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ public void test() {
// such number should not change during checkstyle version upgrade
assertThat(duplicatedRuleWithTemplate).hasSize(0);
// all new Rules should fall in this group
assertThat(rulesWithDuplicateTemplate).hasSize(185);
assertThat(rulesWithDuplicateTemplate).hasSize(186);

for (RulesDefinition.Rule rule : rules) {
assertThat(rule.key()).isNotNull();
Expand Down