-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #502: update to LTS 9.9; cleanup deprecations #503
Conversation
@romani the main project deprecated unfortunately, by doing so, i now receive a CS error:
could you please advise here? |
please add this class to sonar-checkstyle/config/import-control.xml Lines 21 to 22 in 8462c9e
and disallow AutomaticBean when migration is completed. |
5a37b07
to
9f8d2d8
Compare
63f1ffe
to
f69a052
Compare
@romani could you please have a look? 😃 https://app.circleci.com/pipelines/github/checkstyle/sonar-checkstyle/878/workflows/9dfe6b2a-d89d-4cd9-b03b-7d7e95436488/jobs/1035 fails because the SQ java plugin is not compatible with java 11 anymore. i have updated the circleci job to use java 17 but this will only be applied once it's in master. (see change https://github.com/checkstyle/sonar-checkstyle/pull/503/files#diff-78a8a19706dbd2a4425dd72bdab0502ed7a2cef16365ab7030a5a0588927bf47) https://app.circleci.com/pipelines/github/checkstyle/sonar-checkstyle/878/workflows/996f2d0a-8317-4ffe-9d15-027ecedb0db9/jobs/1037 fails but i don't know the reason, tbh. do you have any ideas here? |
Strange, stable failure. Something is this update |
Problem is at this step sonar-checkstyle/.circleci/config.yml Line 26 in f69a052
It might not compatible with docker image for jdk 17, try to remove it or check with git blame why it was added |
cb30b53
to
d151cbb
Compare
142a90b
to
a5cde4e
Compare
Quality Gate passedIssues Measures |
awesome, thanks! 😃 circleci jobs are running through now and i migrated one of them to github actions as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok to merge
fixes #502
fixes #220
fixes #194
Also, remove the deprecated and to be removed
ProfileImporter
andProfileExporter
.Screenshots of the working SQ: