Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace quickfix GIFs by PNGs #631

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

Bananeweizen
Copy link
Collaborator

Also add a more specific one for the NeedBraces quickfix.

There is no functional change, just better support for HiDPI displays.

Also add a more specific one for the NeedBraces quickfix.
@rnveach
Copy link
Member

rnveach commented Jan 21, 2024

@Bananeweizen Isn't quickfixes still broken at #315 .

If so, then I would question how you can be sure this doesn't break anything for something that is already broken.

@Calixte Calixte merged commit 41bb143 into checkstyle:master Jan 25, 2024
7 checks passed
@Calixte
Copy link
Contributor

Calixte commented Jan 25, 2024

@Bananeweizen Isn't quickfixes still broken at #315 .

If so, then I would question how you can be sure this doesn't break anything for something that is already broken.

#315 is fixed by #566 so I was able to verify this works.

@Bananeweizen
Copy link
Collaborator Author

@rnveach I often work on branches which contain multiple of the non-merged PRs in between, because often additional features require the non-merged stuff as prerequisite. I remember being 15 (!) commits ahead of master at some point during a Christmas hacking session. And for this change it really was just replacement of file names by other file names, so that was relatively safe. :)

@Bananeweizen Bananeweizen deleted the png_marker_resolution branch January 25, 2024 15:50
@rnveach
Copy link
Member

rnveach commented Jan 25, 2024

I forgot that there was a PR sitting for it to be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants