Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proper permission for publish-unit-test-result-action #592

Conversation

Calixte
Copy link
Contributor

@Calixte Calixte commented Sep 29, 2023

No description provided.

@rnveach
Copy link
Member

rnveach commented Sep 29, 2023

@Calixte Just curious, how did you know these permissions were needed and which were needed?

@Calixte
Copy link
Contributor Author

Calixte commented Sep 29, 2023

@Calixte Just curious, how did you know these permissions were needed and which were needed?

It's in the README of that action: https://github.com/EnricoMi/publish-unit-test-result-action#permissions

@Bananeweizen Bananeweizen merged commit 1060bd4 into checkstyle:master Sep 29, 2023
7 checks passed
@Bananeweizen
Copy link
Collaborator

@Calixte thanks for looking into that. While I have done my share of Maven and Eclipse, I'm fairly new to GitHub actions. I was also wondering if there is a better way to test such changes than just creating the PR. To my understanding that is sometimes a kind of chicken-and-egg situation when creating a change on an action that should verify a PR, but that PR itself is of course not yet using that changed code (or is it)?

@rnveach
Copy link
Member

rnveach commented Sep 29, 2023

I don't think the PR is using it. That would be a security issue if someone malicious sent a PR.

BTW, @Bananeweizen @Calixte please read https://thehackernews.com/2023/09/github-repositories-hit-by-password.html?m=1 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants